Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-46065: Update for tox-docker 5 and ruff-shared.toml #78

Merged
merged 12 commits into from
Aug 30, 2024

Conversation

jonathansick
Copy link
Member

@jonathansick jonathansick commented Aug 30, 2024

Some assorted project updates that make Times Square work with current dependencies and test infrastructure:

  • Adopt uv and tox-uv for pinning and installing dependencies
  • Pin the tox dependencies with a requirements/tox.[in|txt] file
  • Adapt configuration for tox-docker version 5's randomized connection ports
  • Adopt ruff-shared.toml for common SQuaRE ruff configuration.

- Use tox-uv to speed up installations in tox environments.
- While doing so, adopt the new practice of pinning the tox versions
  that's running for consistency.
- Use a PYTHON_VERSION environment variable in GitHub Actions to make it
  more consistent to update.
Now that tox-docker randomizes its container's ports for reliability,
the configuration needs to pick up the environment variables provided by
tox-docker. Safir does this with the special EnvAsyncPostgresDsn and
EnvRedisDsn connection URL types that look for tox-docker environment
variables.
The expression can be returned directly.
This isn't needed now that redis has its own type annotations.
This is an optimization from Gafaelfawr
This is the modern way of dumping to JSON-serializable data from
Pydantic 2.
@jonathansick jonathansick marked this pull request as ready for review August 30, 2024 22:15
@jonathansick jonathansick merged commit 2527115 into main Aug 30, 2024
4 checks passed
@jonathansick jonathansick deleted the tickets/DM-46065 branch August 30, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant